Skip to content

Prevent that lscpu | grep Flags fails on systems that don't report any flags #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Prevent that lscpu | grep Flags fails on systems that don't report any flags #130

merged 1 commit into from
Nov 14, 2025

Conversation

@bedroge
Copy link
Contributor

@bedroge bedroge commented Nov 14, 2025 •
edited
Loading

The bot/build.sh suddenly failed on a RISC-V node. This node doesn't have any Flags field in the lscpu output:

$ lscpu 
Architecture:          riscv64
  Byte Order:          Little Endian
CPU(s):                4
  On-line CPU(s) list: 0-3

And this causes the grep command introduced in #123 to return 1, and in turn that makes the entire script fail (because of set -e). By adding || echo "") it will just return an empty string in this case.

@bedroge bedroge added the bug Something isn't working label Nov 14, 2025
@casparvl casparvl merged commit ac72cd3 into EESSI:main Nov 14, 2025
64 checks passed
@bedroge bedroge deleted the lscpu_empty_flags_fix branch November 14, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bedroge @casparvl